#761 would this behavior applies to CEL overlays too?

[praveen4g0]

Kind: Question

• apply triggertemplate param default value if body/header based triggerbinding param missing from body/header #761 (apply triggertemplate param default value if body/header based triggerbinding param missing from body/header)

eg:

apiVersion: triggers.tekton.dev/v1alpha1
kind: EventListener
metadata:
  name: example-with-multiple-overlays
spec:
  serviceAccountName: pipeline
  triggers:
    - name: cel-trig
      interceptors:
        - cel:
            overlays:
            - key: truncated_sha
              expression: "body.pull_request.head.sha.truncate(7)"
            - key: branch_name
              expression: "body.ref.split('/')[2]"
      bindings:
      - name: sha
        value: $(extensions.truncated_sha)
      - name: branch
        value: $(extensions.branch_name)
      template:
        spec:
          params:
            - name: sha
            - name: branch
              default: master
          resourceTemplates:
            - apiVersion: tekton.dev/v1beta1
              kind: TaskRun
              metadata:
                generateName: cel-trig-
              spec:
                taskSpec:
                  steps:
                  - image: ubuntu
                    script: |
                      #!/usr/bin/env bash
                      echo "SHA is : $(tt.params.sha). Branch is $(tt.params.branch)"

what happens when user hit sink url, with a payload, where body doesn't contains field ref ?

Actual:

• It ends up with below error

"level":"info","ts":"2021-01-07T12:06:26.168Z","logger":"eventlistener","caller":"sink/sink.go:215","msg":"interceptor stopped trigger processing: %!w(*status.Error=&{0xc000979620})","knative.dev/controller":"eventlistener","/triggers-eventid":"757sq","/trigger":"cel-trig"}

Expected:

• Trigger template should get default value (master), or at least with some appropriate error log.

Environment Details:

tkn version
Client version: 0.13.1
Pipeline version: v0.19.0
Triggers version: v0.10.2

[bigkevmcd]

Your CEL expression is generating an error, so it's not getting to the TriggerTemplate...

You could try something like this as an expression:

has(body.ref) ? body.ref.split('/')[2] : 'main'

[dibyom]

/kind question

[dibyom]

Closing since the issue seems to have been with the CEL expression.

[jmcshane]

@dibyom is this issue supposed to be closed?

[dibyom]

Yup 🤦

/close

[tekton-robot]

@dibyom: Closing this issue.

In response to this:

Yup 🤦

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.