Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for cel expressions demonstrating use of has #947

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Adding tests for cel expressions demonstrating use of has #947

merged 1 commit into from
Feb 9, 2021

Conversation

jmcshane
Copy link
Contributor

@jmcshane jmcshane commented Feb 6, 2021 •
edited
Loading

I was reading through this test to get a handle for the type of expressions I could
use in overlays and filter expressions and noticed that there weren't any tests
demonstrating the capabilities discussed in #890.

This change adds two tests within the existing structure of the cel_test to help
this file be used as a place to go for example expressions that should work or,
alternative, fail.

Changes

Adding some more complex expressions in cel_test

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2021
@tekton-robot
Copy link

Hi @jmcshane. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Adding tests for cel expressions demonstrating use of has
a3fd82f 
I was reading through this test to get a handle for the type of expressions I could
use in overlays and filter expressions and noticed that there weren't any tests
demonstrating the capabilities discussed in tektoncd#890.

This change adds two tests within the existing structure of the cel_test to help
this file be used as a place to go for example expressions that should work or,
alternatively, fail.
@jmcshane jmcshane force-pushed the feature/add-test-for-cel-expressions branch from e8d3dac to a3fd82f Compare February 6, 2021 21:24
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2021
@dibyom
Copy link
Member

dibyom commented Feb 8, 2021

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2021
@dibyom
Copy link
Member

dibyom commented Feb 9, 2021

/approve

/cc @bigkevmcd

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@bigkevmcd
Copy link
Member

/lgtm

I turn to the tests whenever I get an odd CEL query, so makes sense to me.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@tekton-robot tekton-robot merged commit b5493e6 into tektoncd:master Feb 9, 2021
@jmcshane jmcshane deleted the feature/add-test-for-cel-expressions branch February 9, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@vtereso vtereso Awaiting requested review from vtereso

@bigkevmcd bigkevmcd Awaiting requested review from bigkevmcd

Assignees

@bigkevmcd bigkevmcd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmcshane @tekton-robot @dibyom @bigkevmcd