-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger Templates Typo #268
Comments
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
@jenoOvchi thank you for the issue report and sorry about the late reply. |
Never mind - found the issue in https://tekton.dev/vault/triggers-v0.9.1/triggertemplates/ From hugo docs, it looks like hugo can supports this syntax, but it may need to be enabled, as it's disabled by default. |
Looks like https://tekton.dev/docs/triggers/triggertemplates/ but that content was removed / rewritten in tektoncd/triggers#981. Do we need to go back and fix this in previous versions? Also should we be using this emoji syntax or actual unicode emoticons instead? |
I'm not sure we need to go back and fix things as old as |
Hugo supports markdown emojis in the :<name>: format by they are disabled by default. Enable them as might be used in Tekton docs. Fixes tektoncd#268 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Hugo supports markdown emojis in the :<name>: format by they are disabled by default. Enable them as might be used in Tekton docs. Fixes #268 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
In the pargraph "To enable support for arbitrary resource types, the resource templates are internally resolved as byte blobs. As a result, validation on these resources is only done at event processing time (rather than during TriggerTemplate creation). 🚨 As of now, only Tekton resources can be defined within a TriggerTemplate 🚨" rotating_light are not applyed to the last sentence.
The text was updated successfully, but these errors were encountered: