Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden input in dropdown-select fixed #2361

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

tshimber
Copy link
Contributor

Fixes #2360

Check for hiddenInput el added.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit c20ed8d
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/671fafb209565600089c3850
😎 Deploy Preview https://deploy-preview-2361--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amir-ba amir-ba self-requested a review November 7, 2024 08:54
Copy link
Collaborator

@amir-ba amir-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amir-ba amir-ba merged commit 8a04a5e into telekom:main Nov 12, 2024
12 checks passed
amir-ba added a commit that referenced this pull request Nov 26, 2024
* chore: update CODEOWNERS file (#2368)

* fix(nav-item): makes nav-itemcomponent respect the active=false  (#2364)

* fix(drop-down): fixes hidden input in dropdown-select with null check (#2361)

* fix(nav-item): add null check for child element before setting role to menuitem (#2369)

Co-authored-by: Amir Ashkan Baghdoust <amir-ashkan.baghdoust@telekom.de>

* chore(release): publish (#2372)

---------

Co-authored-by: Arturo Castillo Delgado <arturo@arturu.com>
Co-authored-by: tshimber <110041439+tshimber@users.noreply.github.com>
Co-authored-by: Amir Ashkan Baghdoust <amir-ashkan.baghdoust@telekom.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot set properties of undefined (setting 'value')
2 participants