fix(nav-item): add null check for child element on load #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amir-ba
added a commit
that referenced
this pull request
Nov 26, 2024
* chore: update CODEOWNERS file (#2368) * fix(nav-item): makes nav-itemcomponent respect the active=false (#2364) * fix(drop-down): fixes hidden input in dropdown-select with null check (#2361) * fix(nav-item): add null check for child element before setting role to menuitem (#2369) Co-authored-by: Amir Ashkan Baghdoust <amir-ashkan.baghdoust@telekom.de> * chore(release): publish (#2372) --------- Co-authored-by: Arturo Castillo Delgado <arturo@arturu.com> Co-authored-by: tshimber <110041439+tshimber@users.noreply.github.com> Co-authored-by: Amir Ashkan Baghdoust <amir-ashkan.baghdoust@telekom.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the telekom-nav-item component, where an attempt to set the attribute on a child element could result in an error if the child element is null. The fix adds a null check for the child element before setting the role attribute