Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

328 enable typescript #329

Merged
merged 7 commits into from
Jan 25, 2023
Merged

328 enable typescript #329

merged 7 commits into from
Jan 25, 2023

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Jan 21, 2023

Note: dependent on #317 has been merged

See #328

Description

Adds support for typescript alongside js via typscript-eslint and overrides in eslintrc.js

Test scenarios

  • linting rules should match those for current eslint js
  • should compile and run seamlessly with no new warnings or errors (dev)
  • should support and lint .ts files and typescript contained in component script tags (<script lang='ts'>)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file
  • I have created a new issue with the required translations for the currently supported languages

@donnyquixotic donnyquixotic linked an issue Jan 21, 2023 that may be closed by this pull request
@donnyquixotic donnyquixotic self-assigned this Jan 21, 2023
@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 8fbf9ca
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/63cb3fca39a842000948a189
😎 Deploy Preview https://deploy-preview-329--teloscan-stage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 8fbf9ca
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/63cb3fca0d23e200080d6706
😎 Deploy Preview https://deploy-preview-329--dev-mainnet-teloscan.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@donnyquixotic donnyquixotic added the 🔧 Tech Debt Refactoring, library upgrades, documentation label Jan 21, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18613ed
Status: ✅  Deploy successful!
Preview URL: https://88572a3f.teloscan.pages.dev
Branch Preview URL: https://328-enable-typescript.teloscan.pages.dev

View logs

@donnyquixotic donnyquixotic added the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 21, 2023
@donnyquixotic donnyquixotic removed the request for review from ezra-sg January 21, 2023 01:31
@donnyquixotic donnyquixotic changed the base branch from dev to 127-linting January 21, 2023 03:09
@donnyquixotic donnyquixotic removed the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 23, 2023
@donnyquixotic donnyquixotic requested review from ezra-sg and karynemayer and removed request for karynemayer January 23, 2023 16:27
@donnyquixotic donnyquixotic changed the base branch from 127-linting to dev January 24, 2023 17:07
@Viterbo Viterbo merged commit 58fbfcc into dev Jan 25, 2023
@donnyquixotic donnyquixotic deleted the 328-enable-typescript branch February 17, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Tech Debt Refactoring, library upgrades, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable typescript
3 participants