Worker versioning API Changes #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided not to expose (the yet unused) `CompatibleVersionSet.version_set_id`, the set will have multiple IDs internally. The affected projects have been updated: - [x] [Server PR](temporalio/temporal#4170) - [x] [Go SDK PR](temporalio/sdk-go#1089) Also added a `use_versioning` flag to `RespondWorkflowTaskCompletedRequest` to differentiate between the version stamp being used for versioning (matching) purposes or just as a marker.
…oints (#277) * Record intent to use versioning in WorkerVersionStamp * Add build_id to ResetPointInfo
Co-authored-by: Spencer Judge <sjudge@hey.com>
* Add versioning stamp to activity task completions * Add to failed / cancelled events * Change use latest flag to use compat * Add use_versioning flag to capabilities message & comment wording updates
Co-authored-by: Chad Retz <chad.retz@gmail.com> --------- Co-authored-by: Spencer Judge <sjudge@hey.com> Co-authored-by: Chad Retz <chad.retz@gmail.com>
bergundy
reviewed
May 25, 2023
bergundy
approved these changes
May 25, 2023
dnr
reviewed
May 25, 2023
|
|
||
| message NewerBuildExistsFailure { | ||
| // Build ID of the newer compatible build that will receive tasks. | ||
| string latest_build_id = 1; |
There was a problem hiding this comment.
should we rename this to default or newer?
dnr
approved these changes
May 25, 2023
edmondop
pushed a commit
to edmondop/api
that referenced
this pull request
Jun 22, 2023
API changes for the first real release of the worker versioning feature Co-authored-by: Roey Berman <roey@temporal.io> Co-authored-by: David Reiss <david@temporal.io> Co-authored-by: Roey Berman <roey.berman@gmail.com> Co-authored-by: Chad Retz <chad.retz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We've been working in a branch for some time on API changes for versioning. Everything here has already been reviewed independently.
Why?
Versioning feature
Breaking changes
Only to existing-but-unimplemented RPCs