Skip to content

Commit

Permalink
Adjust dev-server tunables to avoid persistence rate-limiting (#626)
Browse files Browse the repository at this point in the history
Rationale is explained in the code comments.

Closes #621.
  • Loading branch information
josh-berry authored Jul 22, 2024
1 parent 8d56e1b commit 29b1eb1
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions temporalcli/commands.server.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,17 @@ import (
)

var defaultDynamicConfigValues = map[string]any{
// Make search attributes immediately visible on creation, so users don't
// have to wait for eventual consistency to happen when testing against the
// dev-server. Since it's a very rare thing to create search attributes,
// we're comfortable that this is very unlikely to mask bugs in user code.
"system.forceSearchAttributesCacheRefreshOnRead": true,

// Since we disable the SA cache, we need to bump max QPS accordingly.
// These numbers were chosen to maintain the ratio between the two that's
// established in the defaults.
"frontend.persistenceMaxQPS": 10000,
"history.persistenceMaxQPS": 45000,
}

func (t *TemporalServerStartDevCommand) run(cctx *CommandContext, args []string) error {
Expand Down

0 comments on commit 29b1eb1

Please sign in to comment.