Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Set higher frontend.persistenceMaxQPS default for dev server #621

Closed
cretz opened this issue Jul 11, 2024 · 1 comment · Fixed by #626
Closed

[Feature Request] Set higher frontend.persistenceMaxQPS default for dev server #621

cretz opened this issue Jul 11, 2024 · 1 comment · Fixed by #626
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jul 11, 2024

Describe the solution you'd like

In 0.11 when we disabled search attribute cache (system.forceSearchAttributesCacheRefreshOnRead=true) and overrode QPS (frontend.persistenceMaxQPS=10000). When we re-disabled SA cache in 0.13.1 in #593, we did not re-override that max QPS setting and users are now hitting it. We should set it as it was in 0.11.
@cretz cretz added the enhancement New feature or request label Jul 11, 2024
@yiminc
Copy link
Member

yiminc commented Jul 11, 2024

may need to bump history.persistenceMaxQPS as well if it is not already higher.

josh-berry added a commit that referenced this issue Jul 19, 2024
@josh-berry
Adjust dev-server tunables to avoid persistence rate-limiting
ef30ccf 
Rationale is explained in the code comments.

Closes #621.
@josh-berry josh-berry mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust dev-server tunables to avoid persistence rate-limiting temporalio/cli
2 participants
@cretz @yiminc