Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept search attributes for dev server and disable cache by default #593

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Accept search attributes for dev server and disable cache by default #593

merged 2 commits into from
Jun 17, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Jun 12, 2024

What was changed

  • server start-dev now accepts --search-attribute key=index-type
  • server start-dev now sets the system.forceSearchAttributesCacheRefreshOnRead dynamic config value to true by default

Checklist

  1. Closes [Feature Request] Add temporal server start-dev --search-attribute CustomKeyword=Keyword #21

@cretz cretz requested a review from a team June 12, 2024 14:32
@cretz cretz merged commit 102da77 into temporalio:main Jun 17, 2024
7 checks passed
@cretz cretz deleted the search-attributes branch June 17, 2024 14:52
@antlai-temporal antlai-temporal mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 20, 2024
Open
Open
Open
Open
Open
Draft
@cretz cretz mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add temporal server start-dev --search-attribute CustomKeyword=Keyword
3 participants
@cretz @Sushisource @Quinn-With-Two-Ns