Add command for workflow update #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samanbarghi
commented
Apr 18, 2023
Comment on lines
+61
to
+62
| FlagUpdateHandlerName = "Update handler Name" | ||
| FlagUpdateHandlerInput = "Args for the Update handler. Formatted in JSON." |
There was a problem hiding this comment.
gofmt reformatted the whole file; these are the new additions.
samanbarghi
commented
Apr 18, 2023
workflow/workflow.go
Outdated
Comment on lines
388
to
419
| { | ||
| Name: "update", | ||
| Usage: common.UpdateWorkflowDefinition, | ||
| UsageText: common.WorkflowUpdateUsageText, | ||
| Flags: append(common.FlagsForExecution, | ||
| &cli.StringFlag{ | ||
| Name: common.FlagUpdateWaitPolicy, | ||
| Usage: "Wait policy determines how long the client should wait for a return value from the server:" + strings.Join(mapKeysToArray(updateWaitPolicyMap), ", "), | ||
| Category: common.CategoryMain, | ||
| Required: true, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: common.FlagName, | ||
| Usage: common.FlagUpdateHandlerName, | ||
| Required: true, | ||
| Category: common.CategoryMain, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: common.FlagInput, | ||
| Aliases: common.FlagInputAlias, | ||
| Usage: common.FlagUpdateHandlerInput, | ||
| Category: common.CategoryMain, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: common.FlagUpdateFirstExecutionRunID, | ||
| Usage: "Do not run update if workflow exectuion (--run-id or if not set, latest workflow execution) is not part of the same execution chain as this id.", | ||
| Category: common.CategoryMain, | ||
| }, | ||
| ), | ||
| Action: func(c *cli.Context) error { | ||
| return UpdateWorkflow(c) | ||
| }, | ||
| }, |
There was a problem hiding this comment.
gofmt reformatted the file, here is the new addition.
samanbarghi
force-pushed
the
features/add-update-workflow-command
branch
from
a4af667
to
f68dcdf
Compare
cretz
reviewed
Apr 19, 2023
bergundy
reviewed
Apr 19, 2023
bergundy
reviewed
Apr 19, 2023
bergundy
reviewed
Apr 19, 2023
bergundy
reviewed
Apr 19, 2023
mmcshane
reviewed
Apr 25, 2023
MichaelSnowden
suggested changes
Apr 25, 2023
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
samanbarghi
force-pushed
the
features/add-update-workflow-command
branch
from
c5f5ba6
to
60f35e8
Compare
Co-authored-by: Michael Snowden <MichaelSnowden@users.noreply.github.com>
MichaelSnowden
approved these changes
Apr 26, 2023
alexshtin
reviewed
Apr 28, 2023
Comment on lines
+42
to
+43
| //TODO: remove this flag when update workflow is enabled in the server by default | ||
| "--dynamic-config-value", "frontend.enableUpdateWorkflowExecution=true", |
There was a problem hiding this comment.
I don't think this should be enabled here. Let it rely on default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added 'workflow update' command to update workflows.
Why?
There is a new feature to update workflows synchronously: temporalio/temporal#3822
This change adds a command to the client to call that API.
Checklist
How was this tested:
Tested locally.
Any docs updates needed?
The "workflow" section of CLI doc should be updated: https://docs.temporal.io/cli/workflow