Add lint to makefile #218
Merged
Add lint to makefile #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
approved these changes
Apr 26, 2023
samanbarghi
added a commit
to samanbarghi/temporal-cli
that referenced
this pull request
Apr 26, 2023
samanbarghi
added a commit
that referenced
this pull request
Apr 27, 2023
* Add update command * Use sdkclient instead of frontend client * Add e2e test for update * Update tests/workflows/update/update.go Co-authored-by: Roey Berman <roey.berman@gmail.com> * Update workflow/workflow.go Co-authored-by: Roey Berman <roey.berman@gmail.com> * Use high level sdk client APIs and remove WaitPolicy for now * Enable update in dev server and uncomment test * Handle result from update comand and print it out * Add new tests and modify e2e suite * Stop server after suite is done * Simplify workflow update test * Add update-id flag to get result of updates * Fix lint issues * Remove update-id flag * fix unbound variable (#215) * Use camel case * Add lint to makefile (#218) * Update tests/workflows/update/update.go Co-authored-by: Michael Snowden <MichaelSnowden@users.noreply.github.com> * Remove extra error checks from test * Remove success message * Use local app and server for each test --------- Co-authored-by: Roey Berman <roey.berman@gmail.com> Co-authored-by: Michael Snowden <MichaelSnowden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add lint to Makefile.
Why?
To run linter against the changes locally