Allow attaching metric meters late #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
fix-prom-startup
branch
from
bae3516 to
165eb50
Compare
Sushisource
changed the title
cretz
approved these changes
Aug 21, 2023
|
|
||
| /// Some metric meters cannot be initialized until after a tokio runtime has started and after | ||
| /// other telemetry has initted (ex: prometheus). They can be attached here. | ||
| pub fn attach_late_init_metrics(&mut self, meter: Arc<dyn CoreMeter + 'static>) { |
Member
There was a problem hiding this comment.
Any reason I shouldn't always use this? It's easier for my code if I don't have some special knowledge of which CoreMeter impl needs late binding and which doesn't.
Member
Author
There was a problem hiding this comment.
Feel free to always do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Allows the starting of the prometheus server after initializing the Core runtime so Tokio will exist.
Why?
Panic bad
Checklist
Closes
How was this tested:
Added integ test
Any docs updates needed?