chore: Update SDK Core to 617612aa #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
commented
Nov 16, 2023
| options.metric_periodicity(Duration::from_millis(metric_periodicity)); | ||
| } | ||
|
|
||
| // FIXME: Move temporality to the otel object |
Contributor
Author
There was a problem hiding this comment.
Move temporality to the otel object
Don't block on this. It will be fixed in upcoming metrics PR. I want to avoid changing lang side API (and therefore deal with deprecation) just for a single release, then change it again on the next release.
Sushisource
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Recently, TS SDK had been built over a custom branch of Core SDK, intentionally ignoring changes that affected Core telemetry support. This PR reconnects to the main branch of Core SDK (though not the latest commit), notably bring in the following PR:
CoreMeterimplementations to use their own custom attribute reference sdk-core#608Note that this PR adds no new feature by itself.