Skip to content

Log errors if metric buffer is full and drop calls rather than blocking #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Log errors if metric buffer is full and drop calls rather than blocking #611

merged 1 commit into from
Sep 29, 2023

Conversation

@Sushisource
Copy link
Member

@Sushisource Sushisource commented Sep 28, 2023

What was changed

Why?

Probably better than locking everything up if the buffer isn't being drained

Checklist

  1. Closes [Feature Request] Drop + log when trying to add metric buffer event and it's full #610
  2. How was this tested:
  1. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner September 28, 2023 20:52
@Sushisource Sushisource enabled auto-merge (squash) September 28, 2023 20:56
@Sushisource Sushisource merged commit 617612a into temporalio:master Sep 29, 2023
@Sushisource Sushisource deleted the drop-metric-buffer-overflow branch September 29, 2023 16:11
@mjameswh mjameswh mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cretz cretz cretz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Drop + log when trying to add metric buffer event and it's full

2 participants

@Sushisource @cretz