Client keep alive, enabled by default #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Sep 26, 2023
| } | ||
|
|
||
| #[test] | ||
| fn keep_alive_defaults() { |
Member
There was a problem hiding this comment.
I dunno how useful this is really, but, since you wrote it I'm fine keeping it too.
Member
Author
There was a problem hiding this comment.
I was scared of my Rust string in the default builder and I wanted to confirm it worked just for me, so I figured why not a test, but I agree in general this is a silly test
Comment on lines
+1479
to
+1480
| .identity("enchicat".to_string()) | ||
| .target_url(Url::parse("https://smolkitty").unwrap()) |
Member
There was a problem hiding this comment.
I am glad you have maintained the traditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Exposed keep alive options, and defaulted them to enabled with 30s interval and 15s timeout by default. See temporalio/features#123.
Checklist