Update api-go to allow invalid UTF-8 in proto strings #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously
tdeebswihart
force-pushed
the
tds/proto-invalid-utf8
branch
2 times, most recently
from
8dad3f9 to
cd94ad4
Compare
tdeebswihart
assigned tdeebswihart, cretz and Quinn-With-Two-Ns and unassigned tdeebswihart
dnr
reviewed
Mar 1, 2024
Quinn-With-Two-Ns
approved these changes
Mar 1, 2024
…1408) ## What was changed This PR adds an integration test to validate that we allow invalid UTF-8 data in strings. ## Testing You will need to run the server locally as of temporalio/temporal#5476, then execute the integration tests. This test has been manually verified as passing on SDK version 1.25.0 and server version 1.22.5, so we should remain compatible with our pre-google/protobuf behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I've upgraded the version of our Go API in order to allow invalid UTF-8 data in our proto strings.
Note that the tests for this behavior are in a separate pr (#1408) as they require unreleased changes to the server.
Why?
The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously
Checklist