bugfix: Mark json value as binary before assigning to field in payload #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Mark the JSON value as binary before assigning to
datakey inApi::Common::V1::Payload.Why?
Ruby protobuf uses ASCII-8BIT encoding for
bytesfields in proto messages. The protobuf gem will attend to force the encoding from UTF8 to ASCII-8BIT when assigning the value, but when UTF8 has multi-byte characters (like an emdash), it fails.LLM's love the emdash, so when I was attempting to switch from coinbase's library to this one, I hit issues with the encoding problem. I had commented on this PR on Coinbase's PR which had the same exact problem: coinbase/temporal-ruby#264
I added tests to demonstrate the problem, if you remove the
.bin the changes you'll see them fail.