Skip to content

bugfix: Mark json value as binary before assigning to field in payload #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cretz merged 1 commit into from
Oct 2, 2025
Merged

bugfix: Mark json value as binary before assigning to field in payload #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/converters/payload_converter/json_protobuf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def to_payload(value, hint: nil) # rubocop:disable Lint/UnusedMethodArgument

Api::Common::V1::Payload.new(
metadata: { 'encoding' => ENCODING, 'messageType' => value.class.descriptor.name },
data: value.to_json
data: value.to_json.b
)
end

Expand Down
11 changes: 11 additions & 0 deletions temporalio/test/converters/payload_converter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,17 @@ def test_default_converter
# outside of Ruby)
require 'json/add/time'
assert_payload time, 'json/plain', time.to_json

# Proto payloads with multi-byte UTF-8 characters (em-dash U+2014) are serialized correctly
proto_with_multibyte = Temporalio::Api::Common::V1::WorkflowExecution.new(workflow_id: 'test — emdash')
payload = assert_payload(
proto_with_multibyte,
'json/protobuf',
# The .b method converts UTF-8 to ASCII-8BIT/binary encoding, which is required by the Payload data field.
# The multi-byte em-dash character (U+2014) becomes the byte sequence \xE2\x80\x94 in UTF-8.
"{\"workflowId\":\"test \xE2\x80\x94 emdash\"}".b
)
assert_equal 'temporal.api.common.v1.WorkflowExecution', payload.metadata['messageType']
end

def test_binary_proto
Expand Down
Loading