Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate metrics on read history and read raw history #3925

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Feb 9, 2023

What changed?
Separate metrics on read history and read raw history

Why?
Read raw history are all system callers.

How did you test it?
local test

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from a team as a code owner February 9, 2023 17:14
@yux0 yux0 enabled auto-merge (squash) February 9, 2023 17:14
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I believe pollForWorkflowTask can also get & return raw history to client. This feature is disabled by default.

@yux0 yux0 merged commit 677890b into temporalio:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants