Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate metrics on read history and read raw history #3925

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Separate metrics on read history and read raw history #3925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93d0634
Separate metrics on read history and read raw history
yux0 Feb 9, 2023
85f225e
Merge branch 'master' into raw-history-metrics
yux0 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/metrics/metric_defs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,8 @@ const (
PersistenceReadHistoryBranchScope = "ReadHistoryBranch"
// PersistenceReadHistoryBranchReverseScope tracks ReadHistoryBranchReverse calls made by service to persistence layer
PersistenceReadHistoryBranchReverseScope = "ReadHistoryBranchReverse"
// PersistenceReadRawHistoryBranchScope tracks ReadRawHistoryBranch calls made by service to persistence layer
PersistenceReadRawHistoryBranchScope = "ReadRawHistoryBranch"
// PersistenceForkHistoryBranchScope tracks ForkHistoryBranch calls made by service to persistence layer
PersistenceForkHistoryBranchScope = "ForkHistoryBranch"
// PersistenceDeleteHistoryBranchScope tracks DeleteHistoryBranch calls made by service to persistence layer
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/persistenceMetricClients.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ func (p *executionPersistenceClient) ReadRawHistoryBranch(
caller := headers.GetCallerInfo(ctx).CallerName
startTime := time.Now().UTC()
defer func() {
p.recordRequestMetrics(metrics.PersistenceReadHistoryBranchScope, caller, startTime, retErr)
p.recordRequestMetrics(metrics.PersistenceReadRawHistoryBranchScope, caller, startTime, retErr)
}()
return p.persistence.ReadRawHistoryBranch(ctx, request)
}
Expand Down