Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Commit

Permalink
Evidence time is sourced from block time (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
cmwaters authored Aug 10, 2020
1 parent e969218 commit 713a773
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
5 changes: 2 additions & 3 deletions spec/abci/abci.md
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,8 @@ via light client.
- `Type (string)`: Type of the evidence. A hierarchical path like
"duplicate/vote".
- `Validator (Validator`: The offending validator
- `Height (int64)`: Height when the offense was committed
- `Time (google.protobuf.Timestamp)`: Time of the block at height `Height`.
It is the proposer's local time when block was created.
- `Height (int64)`: Height when the offense occured
- `Time (google.protobuf.Timestamp)`: Time of the block that was committed at the height that the offense occured
- `TotalVotingPower (int64)`: Total voting power of the validator set at
height `Height`

Expand Down
7 changes: 6 additions & 1 deletion spec/core/data_structures.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ type Evidence interface {
All evidence can be encoded and decoded to and from Protobuf with the `EvidenceToProto()`
and `EvidenceFromProto()` functions. The [Fork Accountability](../consensus/light-client/accountability.md)
document provides a good overview for the types of evidence and how they occur.
document provides a good overview for the types of evidence and how they occur. Each evidence uses
the timestamp of the block that the evidence occured at to indicate the age of the evidence.
`DuplicateVoteEvidence` represents a validator that has voted for two different blocks
in the same round of the same height. Votes are lexicographically sorted on `BlockID`.
Expand All @@ -230,6 +231,8 @@ in the same round of the same height. Votes are lexicographically sorted on `Blo
type DuplicateVoteEvidence struct {
VoteA *Vote
VoteB *Vote

Timestamp time.Time
}
```
Expand All @@ -253,6 +256,8 @@ type LunaticValidatorEvidence struct {
Header *Header
Vote *Vote
InvalidHeaderField string

Timestamp time.Time
}
```
Expand Down

0 comments on commit 713a773

Please sign in to comment.