This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Evidence time is sourced from block time #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
ebuchman,
josef-widder,
konnov and
milosevic
as code owners
erikgrinaker
approved these changes
Aug 10, 2020
spec/core/data_structures.md
Outdated
| @@ -221,7 +221,8 @@ type Evidence interface { | |||
|
|
|||
| All evidence can be encoded and decoded to and from Protobuf with the `EvidenceToProto()` | |||
| and `EvidenceFromProto()` functions. The [Fork Accountability](../consensus/light-client/accountability.md) | |||
| document provides a good overview for the types of evidence and how they occur. | |||
| document provides a good overview for the types of evidence and how they occur. Each evidence uses | |||
| the timestamp of the block of the height that the evidence occured at to indicate the age of the evidence. | |||
There was a problem hiding this comment.
Suggested change
| the timestamp of the block of the height that the evidence occured at to indicate the age of the evidence. | |
| the timestamp of the block that the evidence occured at to indicate the age of the evidence. |
alexanderbez
approved these changes
Aug 10, 2020
|
nit: could you better the wording here as well: https://github.com/tendermint/spec/blob/master/spec/abci/abci.md#evidence |
|
@marbar3778 how does the wording seem now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #133