fix(campaign): add error in IsTotalSharesReached
#879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
aljo242 and
giunatale
as code owners
Codecov Report
@@ Coverage Diff @@
## audit-release #879 +/- ##
=================================================
+ Coverage 11.20% 11.21% +0.01%
=================================================
Files 278 278
Lines 60753 60771 +18
=================================================
+ Hits 6806 6815 +9
- Misses 53761 53767 +6
- Partials 186 189 +3
|
lumtis
added a commit
that referenced
this pull request
Jul 26, 2022
* fix(`campaign`): add error in `IsTotalSharesReached` (#879) * add error to method * update tests * update messages * fix(monitoringc): fix RegisterProviderClientIDFromChannelID description (#881) * refactor: factorize similar store key methods (#882) * launch * campaign * genesis * fix(launch): force port 443 for create-chain command custom genesis (#884) * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error in
IsTotalSharesReachedin case provided shares are not valid (ex: duplicate denoms)