Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync main #904

Merged
merged 9 commits into from
Jul 26, 2022
Merged

chore: sync main #904

merged 9 commits into from
Jul 26, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 25, 2022

Sync main branch with audit fixes

@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #904 (938a3a3) into develop (236026b) will increase coverage by 0.00%.
The diff coverage is 86.04%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #904   +/-   ##
========================================
  Coverage    10.55%   10.56%           
========================================
  Files          327      327           
  Lines        75095    75110   +15     
========================================
+ Hits          7930     7939    +9     
- Misses       66978    66982    +4     
- Partials       187      189    +2
Impacted Files Coverage Δ
x/campaign/keeper/msg_mint_vouchers.go 69.38% <40.00%> (-3.95%) ⬇️
.../campaign/keeper/msg_update_special_allocations.go 94.00% <50.00%> (-6.00%) ⬇️
x/campaign/keeper/mainnet_account.go 100.00% <100.00%> (ø)
x/campaign/types/campaign.go 100.00% <100.00%> (ø)
x/campaign/types/genesis.go 100.00% <100.00%> (ø)
x/campaign/types/shares.go 100.00% <100.00%> (ø)
x/launch/keeper/genesis_account.go 100.00% <100.00%> (ø)
x/launch/keeper/genesis_validator.go 100.00% <100.00%> (ø)
x/launch/keeper/vesting_account.go 100.00% <100.00%> (ø)
x/launch/types/genesis.go 100.00% <100.00%> (ø)

@lumtis lumtis marked this pull request as ready for review July 25, 2022 09:09
aljo242
aljo242 suggested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run make format

@lumtis lumtis requested a review from aljo242 July 25, 2022 12:44
tbruyelle
tbruyelle approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lumtis
Copy link
Contributor Author

lumtis commented Jul 26, 2022

@aljo242 any other comments?

aljo242
aljo242 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@lumtis lumtis merged commit d55fd30 into develop Jul 26, 2022
@lumtis lumtis deleted the chore/sync-main branch July 26, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@giunatale giunatale Awaiting requested review from giunatale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumtis @tbruyelle @aljo242