feat: buf proto generation #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/v0.46.0 #917 +/- ##
=============================================
Coverage 10.56% 10.56%
=============================================
Files 327 327
Lines 75202 75202
=============================================
+ Hits 7942 7944 +2
+ Misses 67071 67070 -1
+ Partials 189 188 -1
|
|
Sounds good. I think we should support or adapt to buf with Ignite CLI |
lumtis
added a commit
that referenced
this pull request
Aug 10, 2022
* add cosmsocmd code * remove cosmoscmd * go mod tidy * format * re-format * fix imports * change ibc to v5 * use storetypes package * fix New command * resolve app.go * update hooks signatures * fix initializer keeper calls * update sim utils * update cli util code * remaining fixes * fix claim suite * fix go.sum * Update cmd/genaccounts.go Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Update x/claim/keeper/mission_delegation_hooks.go Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * move util to testutil * update dependencies for cosmos-proto * feat: buf proto generation (#917) * add .clang-format * setup buf * add scripts and update Makefile * make proto-format * make proto-gen * update fundraising dep * remove ibc fork * use ibc beta release * feat: cosmos proto annotations (#918) * cosmos proto Int * remaining cosmos scalar annotations * proto format * fix(`localnet`): add missing `staking` param for `0.46` (#919) * add missing param * fix init channel * update key info * chore: set binary name in config_2.yml (#921) Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR does?
Adds buf tooling and proto targets. This brings our codebase in line with the Cosmos-SDK and their proto compilation model.
I know we previously wanted to have no scripts in the repo, but this is the only way to get proto compilation working until
igniteis updated. The work done in this PR can also serve as a guide for how to updateignite's proto compilation steps.Either way, I think we should keep the
buftools as they can be pretty helpful.Pulling this into our
v0.46.0branch because that makes the most sense.Most of the modified files are just formatted
.protofile and regenerated.pb.gofiles.