Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set binary name in config_2.yml #921

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Aug 7, 2022

Set custom binary name in config_2.yml to make usage of local spn working when launching spn

The reason for this is that the local spn instance and the spn to launch could have different versions

If cli interface is not compatible, usage of network command fails because the spnd command from the spn to launch built binary will be run with the incompatible keyring of the spn instance

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #921 (c531577) into feat/v0.46.0 (0cb1b07) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           feat/v0.46.0     #921   +/-   ##
=============================================
  Coverage         10.55%   10.55%           
=============================================
  Files               327      327           
  Lines             75202    75202           
=============================================
+ Hits               7939     7941    +2     
+ Misses            67073    67072    -1     
+ Partials            190      189    -1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 82.43% <0.00%> (+1.35%) ⬆️

@lumtis lumtis merged commit 568e8c5 into feat/v0.46.0 Aug 7, 2022
@lumtis lumtis deleted the fix/config-binary branch August 7, 2022 11:05
lumtis added a commit that referenced this pull request Aug 10, 2022
* add cosmsocmd code

* remove cosmoscmd

* go mod tidy

* format

* re-format

* fix imports

* change ibc to v5

* use storetypes package

* fix New command

* resolve app.go

* update hooks signatures

* fix initializer keeper calls

* update sim utils

* update cli util code

* remaining fixes

* fix claim suite

* fix go.sum

* Update cmd/genaccounts.go

Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>

* Update x/claim/keeper/mission_delegation_hooks.go

Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>

* move util to testutil

* update dependencies for cosmos-proto

* feat: buf proto generation (#917)

* add .clang-format

* setup buf

* add scripts and update Makefile

* make proto-format

* make proto-gen

* update fundraising dep

* remove ibc fork

* use ibc beta release

* feat: cosmos proto annotations (#918)

* cosmos proto Int

* remaining cosmos scalar annotations

* proto format

* fix(`localnet`): add missing `staking` param for `0.46` (#919)

* add missing param

* fix init channel

* update key info

* chore: set binary name in config_2.yml (#921)

Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant