This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
Implement NewPrefixDB #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
approved these changes
Mar 14, 2018
Codecov Report
@@ Coverage Diff @@
## develop #164 +/- ##
===========================================
- Coverage 62.64% 62.16% -0.49%
===========================================
Files 58 59 +1
Lines 4235 4379 +144
===========================================
+ Hits 2653 2722 +69
- Misses 1368 1440 +72
- Partials 214 217 +3
Continue to review full report at Codecov.
|
melekes
reviewed
Mar 15, 2018
db/mem_batch.go
Outdated
| case opTypeDelete: | ||
| mBatch.db.DeleteNoLock(op.key) | ||
| for i, op := range mBatch.ops { | ||
| if i < len(mBatch.ops) { |
There was a problem hiding this comment.
I don't understand how's i can be greater than len(mBatch.ops) if we're ranging over it
There was a problem hiding this comment.
oops, you're right, I missed a -1 . I'll add a test.
melekes
approved these changes
Mar 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the MultiStore.