Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Fix flowrate test #165

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Fix flowrate test #165

merged 1 commit into from
Mar 14, 2018

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Mar 14, 2018

NOTE: PR is against jae/dbprefix, not develop.

I discovered this bug while running the test...

@jaekwon jaekwon requested a review from odeke-em March 14, 2018 12:17
@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #165 into jae/dbprefix will increase coverage by 3.79%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           jae/dbprefix    #165      +/-   ##
===============================================
+ Coverage          58.7%   62.5%   +3.79%     
===============================================
  Files                40      59      +19     
  Lines              2492    4296    +1804     
===============================================
+ Hits               1463    2685    +1222     
- Misses              916    1394     +478     
- Partials            113     217     +104
Impacted Files Coverage Δ
log/nop_logger.go 0% <0%> (ø)
log/tracing_logger.go 66.66% <0%> (ø)
merkle/simple_tree.go 62.16% <0%> (ø)
merkle/simple_map.go 71.79% <0%> (ø)
log/logger.go 0% <0%> (ø)
log/tm_logger.go 45.16% <0%> (ø)
pubsub/query/query.go 63.67% <0%> (ø)
pubsub/query/query.peg.go 64.38% <0%> (ø)
flowrate/util.go 60% <0%> (ø)
log/tm_json_logger.go 100% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1977d5...2d6a14a. Read the comment docs.

@jaekwon
Copy link
Contributor Author

jaekwon commented Mar 14, 2018

Related: mxk/go-flowrate#3

@jaekwon jaekwon merged commit fafdef3 into jae/dbprefix Mar 14, 2018
@jaekwon jaekwon deleted the jae/flowratefix branch March 14, 2018 18:09
jaekwon added a commit that referenced this pull request Mar 15, 2018
* encodeByteSlice uses uvarint for length instead of varint
* Implemented NewPrefixDB
* Fix flowrate test (#165)
* Complete implementation and fix tests
* Add tests for MemBatch Write[Sync]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants