Add support for model comparison in what-if plugin v1 #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….].inferences is set.
jameswex
reviewed
Nov 5, 2018
Contributor
jameswex
left a comment
jameswex
left a comment
There was a problem hiding this comment.
this code was already reviewed and updated in a PR outside of the main tensorboard repo. here are some final minor comments.
tensorboard/plugins/interactive_inference/interactive_inference_plugin.py
Show resolved
Hide resolved
...ard/plugins/interactive_inference/tf_interactive_inference_dashboard/tf-inference-panel.html
Show resolved
Hide resolved
jameswex
approved these changes
Nov 6, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to load two models and compare them in facets as well as Datapoint Editor tab.
Adding a model comparison demo to demonstrate this feature as well.
Performance + Fairness and Partial Dependence Plots only use model 1.