program_test: bind to all interfaces #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
These tests are currently broken on IPv6-only systems. While it’s valid
to open a _socket_ that binds to `("localhost", 0)` even if the system
only supports IPv6, it’s not valid to start a _Werkzeug server_ with
host `localhost`, because Werkzeug detects `localhost` as an IPv4
address and will open an `AF_INET` socket, causing catastrophe.
This restores the test behavior prior to #2589, which IMHO isn’t great,
but unbreaks these tests on IPv6-only systems.
Test Plan:
This test still works on my dual-IPv4/IPv6 machine, and now also works
on an IPv6-only machine where previously it failed with `EAFNOSUPPORT`.
wchargin-branch: program-test-bind-all
Contributor
Author
|
WANT_LGTM=any |
Contributor
|
Using host=None by default LGTM |
psybuzz
approved these changes
Sep 23, 2019
nfelt
approved these changes
Sep 23, 2019
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
LGTM on the text fix, but does this have any implications for actually non-test usage of TensorBoard on an IPv6-only machine? Does Werkzeug fail in that case?
If so we might at least want to open a bug for fixing that, since at least occasionally people may have IPv6-only machines in the wild.
Contributor
Author
|
Yes; as far as I can tell, the now-default options will fail on an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These tests are currently broken on IPv6-only systems. While it’s valid
to open a socket that binds to
("localhost", 0)even if the systemonly supports IPv6, it’s not valid to start a Werkzeug server with
host
localhost, because Werkzeug detectslocalhostas an IPv4address and will open an
AF_INETsocket, causing catastrophe.This restores the test behavior prior to #2589, which IMHO isn’t great,
but unbreaks these tests on IPv6-only systems.
Test Plan:
This test still works on my dual-IPv4/IPv6 machine, and now also works
on an IPv6-only machine where previously it failed with
EAFNOSUPPORT.wchargin-branch: program-test-bind-all