Skip to content

program_test: bind to all interfaces #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchargin merged 1 commit into from
Sep 23, 2019
Merged

program_test: bind to all interfaces #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tensorboard/program_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ class _StubApplication(object):

def make_flags(self, **kwargs):
flags = argparse.Namespace()
kwargs.setdefault('bind_all', False)
kwargs.setdefault('host', None)
kwargs.setdefault('bind_all', kwargs['host'] is None)
for k, v in six.iteritems(kwargs):
setattr(flags, k, v)
return flags
Expand All @@ -82,19 +83,19 @@ def testMakeServerBlankHost(self):
# Test that we can bind to all interfaces without throwing an error
server = program.WerkzeugServer(
self._StubApplication(),
self.make_flags(host='', port=0, path_prefix=''))
self.make_flags(port=0, path_prefix=''))
self.assertStartsWith(server.get_url(), 'http://')

def testPathPrefixSlash(self):
#Test that checks the path prefix ends with one trailing slash
server = program.WerkzeugServer(
self._StubApplication(),
self.make_flags(host='', port=0, path_prefix='/test'))
self.make_flags(port=0, path_prefix='/test'))
self.assertEndsWith(server.get_url(), '/test/')

server = program.WerkzeugServer(
self._StubApplication(),
self.make_flags(host='', port=0, path_prefix='/test/'))
self.make_flags(port=0, path_prefix='/test/'))
self.assertEndsWith(server.get_url(), '/test/')

def testSpecifiedHost(self):
Expand Down