mesh: replace broken caches with direct lookups #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a small refactoring to encapsulate direct access to a few private caches into methods. Test Plan: The mesh dashboard still appears to work fine with the standard demo dataset. wchargin-branch: mesh-cache-encapsulate wchargin-source: 297bb38b043c1b48e33d4daccc80123226f249bf
Summary: Fixes #2579, and fixes a few unreported bugs regarding run deletions. These caches were broken, because the underlying data could change but the caches were never updated or invalidated. The behavior that they memoize over is not very expensive (a few shallow copies and parsing of small proto messages), so we simply remove the caches in favor of direct access. If this proves to be too expensive, then we can look into more carefully reinstating the caches. Test Plan: 1. Run the mesh demo to generate data into `mesh_demo/run1` with tag `mesh1`. 2. Start TensorBoard pointing at `mesh_demo`. Verify that the mesh appears. 3. Generate test data into `mesh_demo/run1` with tag `mesh2`, then again into `mesh_demo/run2` with tag `mesh2`. 4. Click TensorBoard’s refresh button, or reload the page, and note that the new meshes appear. 5. Remove the `mesh_demo/run1` directory. 6. Reload TensorBoard, and verify that only one mesh remains, under the correct run. wchargin-branch: mesh-cache-remove wchargin-source: 8887de11f50603d4d4a2352e17c8632d42a7f825
wchargin
changed the base branch from
wchargin-mesh-cache-encapsulate
to
master
wchargin-branch: mesh-cache-remove wchargin-source: 0483d8d5d48cb83fd09318f199942e147e9c04f9
wchargin-branch: mesh-cache-remove wchargin-source: 0483d8d5d48cb83fd09318f199942e147e9c04f9
wchargin-branch: mesh-cache-remove wchargin-source: 7faff50990298b1449f70c5d22360d52eb3b2341
wchargin-branch: mesh-cache-remove wchargin-source: 7faff50990298b1449f70c5d22360d52eb3b2341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2579, and fixes a few unreported bugs regarding run deletions.
These caches were broken, because the underlying data could change but
the caches were never updated or invalidated. The behavior that they
memoize over is not very expensive (a few shallow copies and parsing of
small proto messages), so we simply remove the caches in favor of direct
access. If this proves to be too expensive, then we can look into more
carefully reinstating the caches.
Test Plan:
mesh_demo/run1with tagmesh1.mesh_demo. Verify that the meshappears.
mesh_demo/run1with tagmesh2, thenagain into
mesh_demo/run2with tagmesh2.that the new meshes appear.
mesh_demo/run1directory.correct run.
wchargin-branch: mesh-cache-remove