Proto changes to support experiment name & description. #3234
Conversation
|
Investigating the failure of //tensorboard/pip_package:test_pip_package in Travis |
|
Updated to remove duplicate definition of Experiment. Moved single source of truth to within export_service.proto |
|
|
||
| import "google/protobuf/timestamp.proto"; | ||
|
|
||
| // Metadata about an experiment. |
There was a problem hiding this comment.
It's good form to indicate (once we support updating some of this metadata) which fields are output-only and cannot be directly set by the client. (In this case, all of them except name and description.)
See e.g. https://aip.dev/203#output-only (I don't think we necessarily need to use the programmatic specifier, but having the documentation in a comment is still valuable)
There was a problem hiding this comment.
Yeah, tricky because the metadata is used in several different locations for different purposes.
There was a problem hiding this comment.
Nevertheless, this file has been removed.
|
Delegating to others while I’m out; see my comments on the previous |
|
cc myself |
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
LGTM modulo the one comment left.
Proto changes to support experiment name & description.
5 participants
Motivation for features / changes
Support for experiment name & description in TensorBoard.dev
Technical description of changes
Extends proto service adding:
UpdateExperimentMetadata
OSS product users should see no chnage.
Detailed steps to verify changes work correctly (as executed by you)
$ bazel test //tensorboard/... --test_tag_filters=-webtest --build_tests_only
(this is a continuation of a previous messed up PR #3227 )