Update export/write services for eventual tensor storage #3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I know this will have merge issues with #3234 |
Contributor
Author
|
Found some issues, removed reviewers while I fix it. |
ericdnielsen
requested review from
bileschi and
wchargin
and removed request for
wchargin
Contributor
Author
|
Resolved merge issues post Experiment name/description PR. |
davidsoergel
approved these changes
Feb 12, 2020
|
|
||
| // Data for the Tensors are stored in a columnar fashion to optimize it for | ||
| // exporting the data into textual formats like JSON. | ||
| // The data for the ith scalar is { steps[i], wall_times[i], values[i] }. |
| } | ||
|
|
||
| // Metadata for the TensorPoints stored for one (Experiment, Run, Tag). | ||
| message TensorPointMetadata { |
Member
There was a problem hiding this comment.
Is this used anywhere? It appears forked from ScalarPointMetadata, which is also unused?
Contributor
Author
There was a problem hiding this comment.
Its used in the storage backend, but defined here.
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
…3236) * Update export/write services to add needed fields & calls for eventual tensor storage
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Update export/write services to add needed fields & calls for eventual tensor storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fields to experiment, and subsidiary messages for tensor storage issues. Adds the placeholder request/response. I need these definitions to exist for other dependent changes, and hope we can review these in isolation.
This is not adding implementation of these methods.
We may? want to use oneof for the Tag level Scalars or Tensors points