base_plugin: enforce kwarg-only initializers #3312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These initializers have always been documented as requiring keyword arguments, so this is not a breaking change. We can now use Python 3’s keyword-only argument syntax to actually enforce this. Test Plan: All tests pass, and no Google-internal Python 2 binaries depend on this target. wchargin-branch: base-plugin-kwargs
stephanwlee
approved these changes
Mar 2, 2020
Contributor
Author
|
Merging master into this branch; I expect that this will cause a fast CI |
wchargin-branch: base-plugin-kwargs wchargin-source: cbb58bfcf9bd73e9528cc6f104172f722b202b9b
wchargin-branch: base-plugin-kwargs wchargin-source: a8fb0eeaa13b1abb7cec71350e6d8a4cc8d70bcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These initializers have always been documented as requiring keyword
arguments, so this is not a breaking change. We can now use Python 3’s
keyword-only argument syntax to actually enforce this.
The trailing comma removal is necessary to work around a parser bug in
cPython 3.5: https://bugs.python.org/issue9232
Test Plan:
All tests pass, and no Google-internal Python 2 binaries depend on this
target.
wchargin-branch: base-plugin-kwargs