Skip to content

base_plugin: enforce kwarg-only initializers #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchargin merged 3 commits into from
Mar 6, 2020
Merged

base_plugin: enforce kwarg-only initializers #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b985874
base_plugin: enforce kwarg-only initializers
wchargin Feb 27, 2020
1b27c4f
[update diffbase]
wchargin Mar 6, 2020
a94e355
[update patch]
wchargin Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorboard/plugins/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports_files(["LICENSE"])
py_library(
name = "base_plugin",
srcs = ["base_plugin.py"],
srcs_version = "PY2AND3",
srcs_version = "PY3",
visibility = ["//visibility:public"],
deps = [
"@org_pythonhosted_six",
Expand Down
6 changes: 4 additions & 2 deletions tensorboard/plugins/base_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,13 @@ class FrontendMetadata(object):

def __init__(
self,
*,
disable_reload=None,
element_name=None,
es_module_path=None,
remove_dom=None,
tab_name=None,
is_ng_component=None,
is_ng_component=None
):
"""Creates a `FrontendMetadata` value.

Expand Down Expand Up @@ -246,6 +247,7 @@ class TBContext(object):

def __init__(
self,
*,
assets_zip_provider=None,
data_provider=None,
db_connection_provider=None,
Expand All @@ -255,7 +257,7 @@ def __init__(
multiplexer=None,
plugin_name_to_instance=None,
sampling_hints=None,
window_title=None,
window_title=None
):
"""Instantiates magic container.

Expand Down