Skip to content

Conversation

@anirudh161
Copy link
Contributor

  • Motivation for features / changes

Fixed missing TensorBoard iframes by saving notebook with outputs. Made some minor text changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@stephanwlee stephanwlee requested a review from qiuminxu March 30, 2020 21:58
@stephanwlee
Copy link
Contributor

@anirudh161 did you mean to add the output cell contents? The change is larger than expected and was wondering if that was intended.

@anirudh161
Copy link
Contributor Author

Yes, that was intentional. I sent out this PR as a workaround for the issue where TensorBoard does not get rendered on tensorflow.org and instead outputs broken iframes. Saving outputs in the notebook prevents DevSite from separately running the code cells in the notebooks and causing broken iframes

@wchargin
Copy link
Contributor

@anirudh161: If preserving outputs is intentional, could you please
ensure that this notebook sets private_outputs: false so that
nbfmt.py knows not to erase them? (cc @lamberta)

@anirudh161
Copy link
Contributor Author

Submitted a new PR (#3468 ) with these and a couple of additional changes. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants