-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: update profiler tutorial #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anirudh161
commented
Apr 1, 2020
- Motivation for features / changes:
- Saved the notebooks with outputs enabled (and private outputs disabled) as a workaround to prevent broken iframes rendering on tensorflow.org
- Made some minor text changes and added a link to the Dev Summit 2020 talk
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
For context, this supersedes #3441. |
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As listed in the check failure, please run this through nbfmt.py to
fix formatting errors and make the patch easier to review. The patch as
written is 240 lines, but is only 30 lines after formatting.
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The prose changes look good to me. Was the broken-iframe issue
resolved separately? I don’t see any outputs added in this change, as
suggested by the PR description.
|
That's weird. The outputs were there before I ran nbfmt.py on the notebook. Let me look into it and submit another commit |
|
As I mentioned on #3441, make sure that It doesn’t look like |
|
I was so sure I saved the outputs then! Guess I didn't after all :) I added another commit with outputs saved |
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TensorBoard output cells in this notebook don’t have cache entries
for the profile dashboard. When I open this notebook in Colab and
navigate to the TensorBoard cells without running them, I can use the
scalars dashboard, but the profile dashboard just shows “Not found”.
You can fix this by making sure to load the profile dashboard and select
the correct trace after running all cells in the notebook. The way that
this works is that any requests made during execution are cached when
you save the notebook, so you have to actually load the dashboard and
its data for the requests to persist.
This seems kind of important to me given that it takes multiple minutes
just to run the notebook to the point where it can be interactive, but
I’ll leave it up to you. Shall I merge this as is, or would you like to
fix the cache?
|
That's a good point. I fixed the cache entries and added a new commit |
|
Awesome; thanks! Tested; this works for me both before and after running I’ll go ahead and merge this now. |
Changes:
1. Saved the notebooks with outputs enabled (and private outputs
disabled) as a workaround to prevent broken iframes rendering on
tensorflow.org
2. Made some minor text changes and added a link to the Dev Summit 2020
talk
Changes:
1. Saved the notebooks with outputs enabled (and private outputs
disabled) as a workaround to prevent broken iframes rendering on
tensorflow.org
2. Made some minor text changes and added a link to the Dev Summit 2020
talk