rust: support unbounded reservoirs #4754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `--samples-per-plugin` argument now understands inputs like `scalars=100,images=all`. This indicates that some reservoirs should have unbounded capacity. Reservoir constructors take `impl Into<Capacity>` so that passing a bare `usize` is still valid, enjoying all the concision of dynamic typing alongside the safety of sound static analysis. Test Plan: Due to #4752, passing `--samples_per_plugin=scalars=0` to TensorBoard does not actually work, with or without `--load_fast`. But unit tests have decent coverage, and manual end-to-end tests against a live data server show that it really does return lots of data. wchargin-branch: rust-unbounded-reservoir wchargin-source: 80bee32ce1f8db3c8249435eda75d4d65c973d28
wchargin-branch: rust-unbounded-reservoir wchargin-source: 0dfc407eb057a0dcf6a53093a987f38c25f92b62
wchargin-branch: rust-unbounded-reservoir wchargin-source: 0dfc407eb057a0dcf6a53093a987f38c25f92b62
psybuzz
approved these changes
Mar 9, 2021
Contributor
psybuzz
left a comment
psybuzz
left a comment
There was a problem hiding this comment.
Looks good! It's neat to see a real example of using impl Trait in the argument position: pub fn new(capacity: impl Into<Capacity>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
--samples-per-pluginargument now understands inputs likescalars=100,images=all. This indicates that some reservoirs shouldhave unbounded capacity.
Reservoir constructors take
impl Into<Capacity>so that passing a bareusizeis still valid, enjoying all the concision of dynamic typingalongside the safety of sound static analysis.
Test Plan:
Due to #4752, passing
--samples_per_plugin=scalars=0to TensorBoarddoes not actually work, with or without
--load_fast. But unit testshave decent coverage, and manual end-to-end tests against a live data
server show that it really does return lots of data.
wchargin-branch: rust-unbounded-reservoir