Skip to content

Conversation

@rileyajones
Copy link
Contributor

Motivation for features / changes

We need these new icons to expand and collapse the runs table for the hparams in time series feature.

Technical description of changes

See #6408 for how icons are added

@rileyajones rileyajones requested a review from JamesHollyer June 14, 2023 20:35
@rileyajones rileyajones marked this pull request as ready for review June 14, 2023 22:59

// Keep in sync with the 'svg_bundle' target in tensorboard/webapp/BUILD.
const KNOWN_SVG_ICON = new Set([
'add_24px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, oops

@rileyajones rileyajones merged commit 89ea358 into tensorflow:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants