Skip to content

Add left and right arrow icons #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rileyajones merged 1 commit into from
Jun 15, 2023
Merged

Add left and right arrow icons #6433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tensorboard/webapp/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ tf_svg_bundle(
# 'com_google_material_design_icon' in third_party/js.bzl
srcs = [
"@com_google_material_design_icon//:add_24px.svg",
"@com_google_material_design_icon//:arrow_back_24px.svg",
"@com_google_material_design_icon//:arrow_downward_24px.svg",
"@com_google_material_design_icon//:arrow_forward_24px.svg",
"@com_google_material_design_icon//:arrow_upward_24px.svg",
"@com_google_material_design_icon//:brightness_6_24px.svg",
"@com_google_material_design_icon//:bug_report_24px.svg",
Expand Down
3 changes: 3 additions & 0 deletions tensorboard/webapp/testing/mat_icon_module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ import {FakeMatIconRegistry} from '@angular/material/icon/testing';

// Keep in sync with the 'svg_bundle' target in tensorboard/webapp/BUILD.
const KNOWN_SVG_ICON = new Set([
'add_24px',
Copy link
Contributor

@JamesHollyer JamesHollyer Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch here.

Copy link
Contributor Author

@rileyajones rileyajones Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, oops

'arrow_back_24px',
'arrow_downward_24px',
'arrow_forward_24px',
'arrow_upward_24px',
'brightness_6_24px',
'bug_report_24px',
Expand Down
12 changes: 12 additions & 0 deletions third_party/js.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,14 @@ def tensorboard_js_workspace():
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg",
],
"e1590e051f577d02ec994e7cc6005a2bc96407a3d1ba2d7ce6825fb80402684c": [
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_back/materialicons/24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_back/materialicons/24px.svg",
],
"2f48309fb6ccc7b38a6412757801cd7d07e40b492f64e7146e8899d5a0e7c39a": [
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_forward/materialicons/24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_forward/materialicons/24px.svg",
],
},
rename = {
"ic_arrow_downward_24px.svg": "arrow_downward_24px.svg",
Expand Down Expand Up @@ -272,5 +280,9 @@ def tensorboard_js_workspace():
"https://raw.githubusercontent.com/google/material-design-icons/d3d4aca5a7cf50bc68bbd401cefa708e364194e8/src/action/drag_indicator/materialicons/24px.svg": "drag_indicator_24px.svg",
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg": "add_24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg": "add_24px.svg",
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_back/materialicons/24px.svg": "arrow_back_24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_back/materialicons/24px.svg": "arrow_back_24px.svg",
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_forward/materialicons/24px.svg": "arrow_forward_24px.svg",
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/navigation/arrow_forward/materialicons/24px.svg": "arrow_forward_24px.svg",
},
)