HParam: Implement new Data Table projection architecture in Runs Table #6438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
RunsProjectedTable
branch
4 times, most recently
from
bd75305 to
9ee7d2b
Compare
JamesHollyer
force-pushed
the
RunsProjectedTable
branch
from
9ee7d2b to
fd5fe2a
Compare
rileyajones
approved these changes
Jun 16, 2023
| } | ||
| .row-circle > span { | ||
| border-radius: 50%; | ||
| border: 1px solid rgba(255, 255, 255, 0.4); |
Contributor
There was a problem hiding this comment.
nit: Please use a color from the color sheet instead of an arbitrary rgba value?
Contributor
Author
There was a problem hiding this comment.
This is how it is done in many places. I am leaving it for now. Maybe I will come do a broad change for all circle icons.
| await TestBed.configureTestingModule({ | ||
| imports: [DataTableModule, MatIconTestingModule], | ||
| declarations: [TestableComponent, RunsDataTable], | ||
| // schemas: [NO_ERRORS_SCHEMA], |
Contributor
There was a problem hiding this comment.
Suggested change
| // schemas: [NO_ERRORS_SCHEMA], |
JamesHollyer
added a commit
that referenced
this pull request
Jun 22, 2023
## Motivation for features / changes In #6438 we rewrote the Runs Data Table to use the new projection Data Table structure(Created in #6427 and #6422). This allows us to project custom controls such as the run selection check boxes. This PR implements those checkboxes. ## Technical description of changes Pretty straight forward use of projection. The weird part was that the projected checkbox in the header did not fire the "change" event while the header itself had a subscription to a "click" event for sorting. The solution was to subscribe to the "click" event and that seems to work just fine. ## Screenshots of UI changes (or N/A) All selected: <img width="230" alt="Screenshot 2023-06-20 at 2 40 19 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/164ab4c2-b2bd-47ad-b46d-9dbcf78c976a"> Some selected: <img width="228" alt="Screenshot 2023-06-20 at 2 40 27 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/0822e363-ac08-45a3-9102-4c1959192c9f"> None selected: <img width="211" alt="Screenshot 2023-06-20 at 2 40 35 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/9ce0b8aa-182d-4796-a59b-5e05fc655f2e">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We preparation for adding HParam functionality to both the Scalar Table and the Runs Table we have refactored the Data Table to be more flexible. This refactoring was done in #6422 and #6427 and was only implemented in the Scalar Table because the Runs Table only uses the Data Table behind a flag. This PR implements the new Data Table Structure in the Runs Table.
Technical description of changes
Basically just followed the same structure as the Scalar Table.
Screenshots of UI changes (or N/A)
Runs Table specific styling still needs to be done. It currently looks like this.
We still need to add a column for check boxes and add styling.