HParams: Add selected checkbox column to Runs table #6442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
ProjectRunsEnableControl
branch
from
ff8d11f to
307b424
Compare
JamesHollyer
force-pushed
the
ProjectRunsEnableControl
branch
from
307b424 to
d823d3e
Compare
JamesHollyer
commented
Jun 21, 2023
|
|
||
| .col { | ||
| display: table-cell; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is just a cleanup I bumped into.
JamesHollyer
commented
Jun 21, 2023
| MEAN = 'MEAN', | ||
| RAW_CHANGE = 'RAW_CHANGE', | ||
| HPARAM = 'HPARAM', | ||
| CUSTOM = 'CUSTOM', |
Contributor
Author
There was a problem hiding this comment.
I am considering removing COLOR and using CUSTOM for the color columns.
Contributor
There was a problem hiding this comment.
I understand the rationale here, but I think I prefer leaving them. I think keeping them declared this way helps readability. Feel free to disagree though.
rileyajones
approved these changes
Jun 21, 2023
| MEAN = 'MEAN', | ||
| RAW_CHANGE = 'RAW_CHANGE', | ||
| HPARAM = 'HPARAM', | ||
| CUSTOM = 'CUSTOM', |
Contributor
There was a problem hiding this comment.
I understand the rationale here, but I think I prefer leaving them. I think keeping them declared this way helps readability. Feel free to disagree though.
| const tableData: TableData = { | ||
| id: run.id, | ||
| color: colorMap[run.id], | ||
| selected: (selectionMap && selectionMap.get(run.id)) ?? false, |
Contributor
There was a problem hiding this comment.
I'm only like 80% this is correct, but I think this can be streamlined a bit.
Suggested change
| selected: (selectionMap && selectionMap.get(run.id)) ?? false, | |
| selected: Boolean(selectionMap?.get(run.id)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
In #6438 we rewrote the Runs Data Table to use the new projection Data Table structure(Created in #6427 and #6422). This allows us to project custom controls such as the run selection check boxes. This PR implements those checkboxes.
Technical description of changes
Pretty straight forward use of projection. The weird part was that the projected checkbox in the header did not fire the "change" event while the header itself had a subscription to a "click" event for sorting. The solution was to subscribe to the "click" event and that seems to work just fine.
Screenshots of UI changes (or N/A)
All selected:
Some selected:
None selected: