Skip to content

MDCMigration: Style run table and right pane checkboxes. #6615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmd3k merged 1 commit into from
Oct 3, 2023
Merged

MDCMigration: Style run table and right pane checkboxes. #6615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions tensorboard/webapp/metrics/views/right_pane/settings_view_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ section {
margin: 0 0 12px 0;
}

section .control-row:not(:last-child) {
// Add additional margin between most control elements. The exception is when
// the second control row is a checkbox, in which case we just rely on the
// padding that is already included in the checkbox.
section .control-row:not(:has(+ .control-row > mat-checkbox)):not(:last-child) {
Copy link
Contributor

@rileyajones rileyajones Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 this is a wild selector. I can't figure out how to write this as a single sentence without being a runon.
A .control-row that is inside of a section and comes immediately after another .control-row which contains a mat-checkbox and is not the :last-child.

margin-bottom: 12px;
}

Expand Down Expand Up @@ -89,6 +92,20 @@ section .control-row:not(:last-child) {
}
}

mat-checkbox {
// Counteract the padding of the checkbox in order to align it vertically
// with other items in the pane.
margin-left: -11px;

::ng-deep label {
@include tb-theme-foreground-prop(color, secondary-text);
font-size: 12px;
letter-spacing: normal;
padding-left: 0px;
white-space: nowrap;
}
}

mat-slider {
flex: 1;
// Reset mat-slider's internal extra space on left/right sides
Expand Down Expand Up @@ -125,12 +142,8 @@ tb-dropdown {
display: block;
}

.linked-time {
padding: 5px 0;
}

.control-row {
.indent {
margin-left: 25px;
margin-left: 28px;
}
}
4 changes: 0 additions & 4 deletions tensorboard/webapp/runs/views/runs_table/runs_data_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ tb-data-table-header-cell {
vertical-align: middle;
@include tb-theme-foreground-prop(border-bottom, border, 1px solid);

&:first-child {
padding-left: 16px;
}

&:last-child {
@include tb-theme-foreground-prop(border-right, border, 1px solid);
}
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/widgets/data_table/header_cell_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $_icon_size: 12px;

:host {
display: table-cell;
padding: 2px;
padding: 4px;
vertical-align: bottom;

&:hover {
Expand Down