MDCMigration: Style run table and right pane checkboxes. #6615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
force-pushed
the
mdc-migration-checkboxes-02
branch
from
9f49dd1 to
ab906b2
Compare
rileyajones
approved these changes
Oct 2, 2023
| // Add additional margin between most control elements. The exception is when | ||
| // the second control row is a checkbox, in which case we just rely on the | ||
| // padding that is already included in the checkbox. | ||
| section .control-row:not(:has(+ .control-row > mat-checkbox)):not(:last-child) { |
Contributor
There was a problem hiding this comment.
😆 this is a wild selector. I can't figure out how to write this as a single sentence without being a runon.
A .control-row that is inside of a section and comes immediately after another .control-row which contains a mat-checkbox and is not the :last-child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyle the checkboxes in both the runs table and right pane.
For runs table this is mostly just about removing and adjusting padding.
For right pane this:
Here are some sample screenshots but please patch it in locally to play with it: