MDCMigration: fix readme button color #6621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
reviewed
Oct 4, 2023
| } | ||
|
|
||
| .readme mat-icon { | ||
| color: #fff; |
Contributor
There was a problem hiding this comment.
Could you read this from the palette instead?
Contributor
Author
There was a problem hiding this comment.
I am trying to stay consistent with the other buttons.
Contributor
Author
There was a problem hiding this comment.
Oh cool. Thanks for catching this!
rileyajones
approved these changes
Oct 4, 2023
Contributor
Author
|
This was done in #6620. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Make the readme link mat-icon look like all the other buttons by forcing the color to be white instead of the color of the anchor tag. Note: the header keeps all the same colors in dark mode.
Screenshots of UI changes (or N/A)
Before this change:
After this change:
