Skip to content

MDCMigration: fix readme button color #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesHollyer wants to merge 1 commit into from
Closed

MDCMigration: fix readme button color #6621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tensorboard/webapp/header/header_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,7 @@ settings-button {
height: 100%;
overflow: hidden;
}

.readme mat-icon {
color: #fff;
Copy link
Contributor

@rileyajones rileyajones Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you read this from the palette instead?

Copy link
Contributor Author

@JamesHollyer JamesHollyer Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to stay consistent with the other buttons.

Copy link
Contributor

@bmd3k bmd3k Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I took care of this in #6620.

Copy link
Contributor Author

@JamesHollyer JamesHollyer Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool. Thanks for catching this!

}