Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build tfjs-backend-webgl with Bazel #5277

Closed
mattsoulanille opened this issue Jul 1, 2021 · 1 comment
Closed

Build tfjs-backend-webgl with Bazel #5277

mattsoulanille opened this issue Jul 1, 2021 · 1 comment
Assignees
@ahmedsabie

Comments

@mattsoulanille
Copy link
Member

This issue is part of the Adopt Bazel project and tracks converting the above package(s) to build with Bazel. For details on how to convert a package, take a look at the Bazel Migration doc.

Depends on #5275
This was referenced Jul 1, 2021
Closed
Open
Closed
Open
Open
@ahmedsabie ahmedsabie self-assigned this Jul 15, 2021
@mattsoulanille mattsoulanille mentioned this issue Aug 12, 2021
Merged
mattsoulanille added a commit that referenced this issue Aug 12, 2021
@mattsoulanille
Revert "Build tfjs-backend-webgl with Bazel (#5339)" (#5476)
178ca05 
This reverts commit 86ad5e0 and resolves conflicts. The WebGL Bazel PR had an issue that wasn't caught in code review (my bad!) that prevents tests from running correctly. Reverting it for now is likely the fastest way to unblock the next release.

Fixes #5418
Reopens #5277
@mattsoulanille
Copy link
Member Author

Closed by #5562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedsabie ahmedsabie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsoulanille @ahmedsabie