Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL tests are running incorrectly #5418

Closed
mattsoulanille opened this issue Aug 2, 2021 · 1 comment · Fixed by #5476
Closed

WebGL tests are running incorrectly #5418

mattsoulanille opened this issue Aug 2, 2021 · 1 comment · Fixed by #5476
Assignees
Labels
bazel Issues or PRs related to the Bazel build system RELEASE BLOCKER These issues must be resolved before the next release. type:bug Something isn't working

Comments

@mattsoulanille
Copy link
Member

mattsoulanille commented Aug 2, 2021

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow.js):
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
  • TensorFlow.js installed from (npm or script link):
  • TensorFlow.js version (use command below):
  • Browser version:
  • Tensorflow.js Converter Version:

Describe the current behavior
WebGL tests are running core tests using the CPU backend, and the WebGL tests themselves are not actually being run.

Describe the expected behavior
WebGL runs core tests using the webgl backend and runs its own tests.

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/CodePen/any notebook.

  1. In tfjs-backend-webgl, run yarn bazel run :tfjs-backend-webgl_test.
  2. Click debug on the Chrome window that opens.
  3. Open the chrome debug tools.
  4. Search for a webgl test name in the logs, e.g. fromPixels + regular math opfromPixels + regular math op from webgl_ops_test.ts. It does not appear in the logs, meaning that test was not run.
  5. Open a tfjs-core test, e.g. mat_mul_test.ts, and pause in a spec. Then, look at _tfengine.backendName. It is cpu.

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@mattsoulanille mattsoulanille added type:bug Something isn't working RELEASE BLOCKER These issues must be resolved before the next release. bazel Issues or PRs related to the Bazel build system labels Aug 2, 2021
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

mattsoulanille added a commit that referenced this issue Aug 12, 2021
This reverts commit 86ad5e0 and resolves conflicts. The WebGL Bazel PR had an issue that wasn't caught in code review (my bad!) that prevents tests from running correctly. Reverting it for now is likely the fastest way to unblock the next release.

Fixes #5418
Reopens #5277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel Issues or PRs related to the Bazel build system RELEASE BLOCKER These issues must be resolved before the next release. type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants